Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR checks perf improvements and organization #568

Merged
merged 46 commits into from
Apr 3, 2024
Merged

PR checks perf improvements and organization #568

merged 46 commits into from
Apr 3, 2024

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Apr 1, 2024 •
edited
Loading

Result when from 30-35min pipelines to under 20min

  • Use corepack to install pnpm: Faster and respect the pnpm version set in package.json instead of having another place to keep up to date
  • dependency cache
  • move swagger check to seperate job
  • upgrade to new code coverage task
  • Don't run core tests in ci
  • Move all consitency check to independent github action workflow(Makes it easier to see which one failed immediately without having to open devops and dig into the steps)

@timotheeguerin timotheeguerin marked this pull request as draft April 1, 2024 19:58
@timotheeguerin timotheeguerin changed the title Use cache and corepack PR performance improvements Apr 1, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Apr 1, 2024 •
edited
Loading

All changed packages have been documented.

@azure-sdk
Copy link
Collaborator

You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/568/

Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/568/

@timotheeguerin timotheeguerin changed the title PR performance improvements PR checks perf improvements and organization Apr 2, 2024
@timotheeguerin timotheeguerin added this pull request to the merge queue Apr 2, 2024
@timotheeguerin timotheeguerin removed this pull request from the merge queue due to a manual request Apr 2, 2024
@timotheeguerin timotheeguerin added this pull request to the merge queue Apr 2, 2024
Merged via the queue into Azure:main with commit 0551990 Apr 3, 2024
21 checks passed
@timotheeguerin timotheeguerin deleted the improve-pr-speed branch April 3, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markcowl markcowl markcowl approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@iscai-msft iscai-msft Awaiting requested review from iscai-msft iscai-msft is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timotheeguerin @azure-sdk @markcowl